----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58628/#review172862 -----------------------------------------------------------
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionListenerDUnitTest.java Lines 146 (patched) <https://reviews.apache.org/r/58628/#comment245878> typo: bucket geode-core/src/test/java/org/apache/geode/internal/cache/PartitionListenerDUnitTest.java Lines 149 (patched) <https://reviews.apache.org/r/58628/#comment245879> If afterSecondary is invoked more than once, do we want the test to fail? geode-core/src/test/java/org/apache/geode/internal/cache/PartitionListenerDUnitTest.java Lines 157 (patched) <https://reviews.apache.org/r/58628/#comment245880> should this be fore VM2 and not VM1? Same as before, do we want the test to fail when it gets into that situation or do we want to just ignore it and adjust the expected number of times? - Jason Huynh On April 21, 2017, 9:14 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58628/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 9:14 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, Jason Huynh, > and Lynn Gallinat. > > > Bugs: GEODE-2785 > https://issues.apache.org/jira/browse/GEODE-2785 > > > Repository: geode > > > Description > ------- > > Verify that all buckets lost primary get the afterSecondary callbacks. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/internal/cache/PartitionListenerDUnitTest.java > 7fd470f > > > Diff: https://reviews.apache.org/r/58628/diff/3/ > > > Testing > ------- > > precheckin > > > Thanks, > > Eric Shu > >
