> On April 6, 2017, 12:21 a.m., Darrel Schneider wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/SearchLoadAndWriteProcessor.java > > Line 220 (original), 222 (patched) > > <https://reviews.apache.org/r/58225/diff/1/?file=1685574#file1685574line222> > > > > did you look into using this existing "pendingResponders" instead of > > adding the new "departedMembers" list? > > > > If you get a response message from a member that is not in > > pendingResponders then ignore it. > > > > Hmmm... incomingResponse already checks pendingResponders so perhaps > > that part of the fix is not needed? The only problem I see is that when > > netSearchForBlob is doing the replicates one at a time it does not set > > pendingResponders
pendingResponders is used for QueryMessage, which may have impact when processing netsearch reply message. Use the new list seems safer. - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58225/#review171175 ----------------------------------------------------------- On April 5, 2017, 10:20 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58225/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 10:20 p.m.) > > > Review request for geode, anilkumar gingade and Darrel Schneider. > > > Bugs: GEODE-2757 > https://issues.apache.org/jira/browse/GEODE-2757 > > > Repository: geode > > > Description > ------- > > Do not process netsearch reply from a departed node that membership listener > already detected. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java > fa02574 > > geode-core/src/main/java/org/apache/geode/internal/cache/SearchLoadAndWriteProcessor.java > 3d969f9 > > geode-core/src/test/java/org/apache/geode/internal/cache/SearchLoadAndWriteProcessorTest.java > bfe78b0 > > > Diff: https://reviews.apache.org/r/58225/diff/1/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
