----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58050/ -----------------------------------------------------------
Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, and Swapnil Bawaskar. Repository: geode Description ------- Also: Collapsed unrelated exception catch blocks. Diffs ----- geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java a1d03e45dd4d6559bd9a0869c7dd95908d1858ca geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java 3f147c19a128dce78c51c31e6758e517cd2ab496 geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java d74f5d6b4fce9a44d9eeebdfc7dcf716e9b1652b Diff: https://reviews.apache.org/r/58050/diff/1/ Testing ------- Manual verification of behavior both with and without --dir option, both connected via HTTP and not. I should write some unit tests for it, but would like to pair on that since these tests would be more involved than a copy-paste-modify of the other unit test I "wrote." Question: do we prefer to be consistent with previously existing behavior, or consistent in behavior across connection types? That initial conditional is only in place to preserve existing behavior, where the non-HTTP connection defaults to placing logs in the locator's directory. Without that block, we would move logs to the current working directory, which would be consistent with the via-HTTP scenario. Thanks, Patrick Rhomberg
