[
https://issues.apache.org/jira/browse/GEODE-2687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930821#comment-15930821
]
ASF GitHub Bot commented on GEODE-2687:
---------------------------------------
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/61#discussion_r106755238
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1812,17 +1812,32 @@ std::string
CacheHelper::generateGeodeProperties(const std::string& path,
msg += "enable-network-partition-detection=false\n";
if (ssl) {
- msg += "jmx-manager-ssl-enabled=false\n";
- msg += "cluster-ssl-enabled=true\n";
- msg += "cluster-ssl-require-authentication=true\n";
- msg += "cluster-ssl-ciphers=TLS_RSA_WITH_AES_128_CBC_SHA\n";
- msg += "cluster-ssl-keystore-type=jks\n";
- msg += "cluster-ssl-keystore=" + keystore + "/server_keystore.jks\n";
- msg += "cluster-ssl-keystore-password=gemstone\n";
- msg += "cluster-ssl-truststore=" + keystore +
"/server_truststore.jks\n";
- msg += "cluster-ssl-truststore-password=gemstone\n";
- msg += "security-username=xxxx\n";
- msg += "security-userPassword=yyyy \n";
+ if (untrustedCert){
--- End diff --
Much like keystore is a parameter to this method, could this if-then-else
statement be collapsed to a single set of concatenations that use a (possibly
empty) prefix string, e.g., "untrusted_"?
> create a test for failed SSL auth
> ---------------------------------
>
> Key: GEODE-2687
> URL: https://issues.apache.org/jira/browse/GEODE-2687
> Project: Geode
> Issue Type: Test
> Components: native client
> Reporter: Ernest Burghardt
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
