----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57522/#review168909 -----------------------------------------------------------
Ship it! Ship It! - Jared Stewart On March 13, 2017, 10:31 p.m., Ken Howe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57522/ > ----------------------------------------------------------- > > (Updated March 13, 2017, 10:31 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Kirk > Lund, Patrick Rhomberg, and Swapnil Bawaskar. > > > Repository: geode > > > Description > ------- > > Restored original functionality when launcher process exits. Unintentionally > omitted this when refactoring from using exitValue() to isAlive() > > Check for string "null" in server/locator status message to prevent > interrupting the string of dots. > > Refactored server and locator start commands to use JDK 1.8 Process.isAlive > instead of a try/catch with Process.exitValue > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > d42d75e > > > Diff: https://reviews.apache.org/r/57522/diff/2/ > > > Testing > ------- > > Ran spotlessApply > Re-started precheckin > > > Thanks, > > Ken Howe > >
