----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57522/#review168688 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java Line 389 (original) <https://reviews.apache.org/r/57522/#comment240960> If the locatorProcess exits in this loop, it looks like the old code would have returned an error result. Unless I'm missing something, it seems to me that new version will not throw an error here, but continue as though everything is normal. Perhaps something like this would more closely mimick the old behavior: ``` if (locatorProcess.isAlive()){ ... } else { final int exitValue = locatorProcess.exitValue(); return ResultBuilder.createShellClientErrorResult( String.format(CliStrings.START_LOCATOR__PROCESS_TERMINATED_ABNORMALLY_ERROR_MESSAGE, exitValue, locatorLauncher.getWorkingDirectory(), message.toString())); } - Jared Stewart On March 10, 2017, 11:38 p.m., Ken Howe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57522/ > ----------------------------------------------------------- > > (Updated March 10, 2017, 11:38 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Kirk > Lund, Patrick Rhomberg, and Swapnil Bawaskar. > > > Repository: geode > > > Description > ------- > > Check for string "null" in server/locator status message to prevent > interrupting the string of dots. > > Refactored server and locator start commands to use JDK 1.8 Process.isAlive > instead of a try/catch with Process.exitValue > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > d42d75e83da4f99662c20f955526127d0aaf0b35 > > > Diff: https://reviews.apache.org/r/57522/diff/1/ > > > Testing > ------- > > Manually tested using gfsh > Precheckin has been started > > > Thanks, > > Ken Howe > >
