----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57514/#review168792 -----------------------------------------------------------
Fix it, then Ship it! I think we renamed the tests but missed ExportLogsCommand.java. geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java Line 53 (original), 53 (patched) <https://reviews.apache.org/r/57514/#comment241046> I thought we renamed this to ExportLogsCommand.java? - Kirk Lund On March 13, 2017, 5:32 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57514/ > ----------------------------------------------------------- > > (Updated March 13, 2017, 5:32 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, > and Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > * correctly output error message if gfsh execution has an error > * export logs should output correct log message over http connection as well > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java > 36d071c153ed8c2559cc8c29e248058b42cbf7ff > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/ExportLogController.java > 0351573f6eda80e1751bd6b95efdbe6ce36a620d > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportStatsDUnitTest.java > b7f8c2a080614ab59dc9da29c31f606749b58e4a > > geode-core/src/test/java/org/apache/geode/management/internal/web/controllers/ExportLogControllerTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > f3674581d6e27bba8932294152cc2db8727a4024 > > geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOverHttpDUnitTest.java > cc4ae28ff97fc50c3a9298ea3355847008776ec3 > > geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOverHttpIntegrationTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/57514/diff/2/ > > > Testing > ------- > > precheckin running ... > > > Thanks, > > Jinmei Liao > >
