[ 
https://issues.apache.org/jira/browse/GEODE-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904247#comment-15904247
 ] 

ASF subversion and git services commented on GEODE-2595:
--------------------------------------------------------

Commit b74a0bd4fc867d80d2ac13066321f7547fb3688e in geode's branch 
refs/heads/develop from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b74a0bd ]

GEODE-2595: Change LuceneService.createIndex to use a factory

Changing LuceneService.createIndex to createIndexFactory and
using a factory pattern to create the index.

This allows us to introduce new options to the index create without
breaking backwards compatibility in the future.


> Change LuceneService.createIndex to use a factory pattern
> ---------------------------------------------------------
>
>                 Key: GEODE-2595
>                 URL: https://issues.apache.org/jira/browse/GEODE-2595
>             Project: Geode
>          Issue Type: Improvement
>          Components: lucene
>            Reporter: Dan Smith
>
> Before we remove the Experimental annotation from the LuceneService, we 
> should change createIndex to use a factory pattern rather than having a 
> single method with parameters to create the index. In other words, the method 
> needs to change from:
> {code}
> luceneService.createIndex(region, index, ...)
> {code}
> to
> {code}
> luceneService.createIndexFactory()
>   .setXXX()
>   .setYYY()
>   .create()
> {code}
> This will allow us to add additional set methods in the future to configure 
> other things like the async event queue batch size, etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to