[
https://issues.apache.org/jira/browse/GEODE-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903204#comment-15903204
]
ASF GitHub Bot commented on GEODE-2595:
---------------------------------------
Github user metatype commented on the issue:
https://github.com/apache/geode/pull/421
API changes look good to me. There's a compile error in a test.
> Change LuceneService.createIndex to use a factory pattern
> ---------------------------------------------------------
>
> Key: GEODE-2595
> URL: https://issues.apache.org/jira/browse/GEODE-2595
> Project: Geode
> Issue Type: Improvement
> Components: lucene
> Reporter: Dan Smith
>
> Before we remove the Experimental annotation from the LuceneService, we
> should change createIndex to use a factory pattern rather than having a
> single method with parameters to create the index. In other words, the method
> needs to change from:
> {code}
> luceneService.createIndex(region, index, ...)
> {code}
> to
> {code}
> luceneService.createIndexFactory()
> .setXXX()
> .setYYY()
> .create()
> {code}
> This will allow us to add additional set methods in the future to configure
> other things like the async event queue batch size, etc.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
