+1 experimental means changing. Go for it. -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771
On Feb 24, 2017 7:30 PM, "Kirk Lund" <kl...@apache.org> wrote: > +1 for merging in these changes even though they break rolling upgrade for > redis storage format -- it should be ok to break API or data format if it > was "experimental" in all releases so far > > On Fri, Feb 24, 2017 at 3:25 PM, Bruce Schuchardt <bschucha...@pivotal.io> > wrote: > > > Gregory Green has posted a pull request that warrants discussion. It > > improves performance for Sets and Hashes by altering the storage format > for > > these collections. As such it will not permit a rolling upgrade, though > > the Redis adapter is labelled "experimental" so maybe that's okay. > > > > https://github.com/apache/geode/pull/404 > > > > The PR also fixes GEODE-2469, inability to handle hash keys having > colons. > > > > There was some discussion about altering the storage format that was > > initiated by Hitesh. Personally I think Gregory's changes are better > than > > the current implementation and we should accept them, though I haven't > gone > > through the code changes extensively. > > > > >
