----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57046/#review166754 -----------------------------------------------------------
Fix it, then Ship it! I think there is also some stuff on LuceneResultStruct geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryFactoryImpl.java (line 64) <https://reviews.apache.org/r/57046/#comment238802> Shouldn't we remove this whole method? - Dan Smith On Feb. 24, 2017, 8:39 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57046/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2017, 8:39 p.m.) > > > Review request for geode, Dan Smith and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Removed setProjectionFields > Remove deprecated tag from destroyIndex, technically should throw an > UnsupportedOperationException but there is already a reviewboard request for > having this implemented. > Fixed formatting of waituntilflushed method > > > Diffs > ----- > > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryFactory.java > 4c81f07 > geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java > 6fffe09 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryFactoryImpl.java > 798afce > > Diff: https://reviews.apache.org/r/57046/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
