----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56459/#review164743 -----------------------------------------------------------
I think it might be a good idea to add a test using GfshShellConnectionRule to verify that "gfsh connect" fails immediately when connecting to a secured locator if no password is specified. - Jared Stewart On Feb. 8, 2017, 7:04 p.m., Kevin Duling wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56459/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 7:04 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-2247: GFSH connect over HTTP without credentials should fail earlier > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java > 6507295cd28b5f45f4de164c86c176f467a20f6e > > geode-core/src/main/java/org/apache/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java > fa052489772e3e03eb865d17dbbcb7e227813c42 > > Diff: https://reviews.apache.org/r/56459/diff/ > > > Testing > ------- > > Log of UX on https://issues.apache.org/jira/browse/GEODE-2247 > precheckin running > > > Thanks, > > Kevin Duling > >
