> On Feb. 8, 2017, 7:46 p.m., Kirk Lund wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java, > > line 69 > > <https://reviews.apache.org/r/56425/diff/1/?file=1627169#file1627169line69> > > > > I don't think this code should be in geode-core. This looks like > > something that should be in geode-assembly. And then I think within > > geode-assembly there should be a better way to do this. Casting the review > > wider to include Anthony and Dan is highly reocmmended > > Anthony Baker wrote: > Looks like this rule would only work for tests in geode-assembly. I > agree that it should be moved.
If we let gradle set GEODE_HOME as discussed below then we can get rid of this method. - Jared ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56425/#review164750 ----------------------------------------------------------- On Feb. 8, 2017, 3:03 a.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56425/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 3:03 a.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-2272: do not use a new method to start locator with pulse > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java > b5472909eec8d5ca124e7bfd5c6cb71864d9bbee > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > 1f0cd9e720e732c2ce06515c16601e1df173ff4f > > Diff: https://reviews.apache.org/r/56425/diff/ > > > Testing > ------- > > > Thanks, > > Jinmei Liao > >
