----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56425/#review164751 -----------------------------------------------------------
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java (line 105) <https://reviews.apache.org/r/56425/#comment236512> I didn't notice use of "gemfire.home" before but given this is geode code, we shouldn't use "gemfire.home" I thought Anthony and Dan had worked to remove all env vars and uses of gemfire.home or geode.home from our tests and code. geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java (line 146) <https://reviews.apache.org/r/56425/#comment236513> Another use of setting "gemfire.home" system property. I don't know what the correct approach is but I think this is wrong. - Kirk Lund On Feb. 8, 2017, 3:03 a.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56425/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 3:03 a.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-2272: do not use a new method to start locator with pulse > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java > b5472909eec8d5ca124e7bfd5c6cb71864d9bbee > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > 1f0cd9e720e732c2ce06515c16601e1df173ff4f > > Diff: https://reviews.apache.org/r/56425/diff/ > > > Testing > ------- > > > Thanks, > > Jinmei Liao > >
