-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56355/#review164438
-----------------------------------------------------------




geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
 (line 101)
<https://reviews.apache.org/r/56355/#comment236156>

    I'll remove the comment but re reading it, I think it can still happen in 
rare cases.  It's the issue I am trying to track down but it reproduces at such 
a low rate.



geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java
 (line 118)
<https://reviews.apache.org/r/56355/#comment236155>

    When the exception gets thrown locally (from function execution on the 
executing node itself) the function exception makes it all the way to the 
caller of the execute method.  It behaves differently when failing on a remote 
node from what I can tell.


- Jason Huynh


On Feb. 6, 2017, 11:47 p.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56355/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2017, 11:47 p.m.)
> 
> 
> Review request for geode, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> We will occasionally see EOF exceptions due to file segments being empty
> 
> This diff also reinstates the query retry.  This is needed to automatically 
> retry a query when a bucket is moved mid query execution.
> 
> Added a few null checks
> Added additional logging for exceptional cases
> 
> 
> Diffs
> -----
> 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
>  f64ca82 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java
>  2b244e7 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java
>  4ac987d 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/directory/FileIndexInput.java
>  4b1fc81 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/directory/RegionDirectory.java
>  f1af7f3 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/File.java
>  11647f1 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/FileSystem.java
>  fb1913e 
> 
> Diff: https://reviews.apache.org/r/56355/diff/
> 
> 
> Testing
> -------
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Reply via email to