----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56355/#review164436 -----------------------------------------------------------
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java (line 119) <https://reviews.apache.org/r/56355/#comment236151> If there is an exception and a retry occurs we still increment the stat in the finally block <LuceneFunction.java> stats.endQuery(start, mergedResult == null ? 0 : mergedResult.size()); ->stats.incInt(queryExecutionsId, 1); - This may have caused the issue in stat tests where we expect one query execution but we find multiple execution. - I think we should not increment the count if there was an exception. - I will put in the fix for GEODE-2403 after your changes are checked in. [planning to put a function to decrement the stats in case of exception] - nabarun nag On Feb. 6, 2017, 11:47 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56355/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 11:47 p.m.) > > > Review request for geode, nabarun nag, Dan Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > We will occasionally see EOF exceptions due to file segments being empty > > This diff also reinstates the query retry. This is needed to automatically > retry a query when a bucket is moved mid query execution. > > Added a few null checks > Added additional logging for exceptional cases > > > Diffs > ----- > > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java > f64ca82 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java > 2b244e7 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java > 4ac987d > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/directory/FileIndexInput.java > 4b1fc81 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/directory/RegionDirectory.java > f1af7f3 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/File.java > 11647f1 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/FileSystem.java > fb1913e > > Diff: https://reviews.apache.org/r/56355/diff/ > > > Testing > ------- > > geode-lucene:precheckin > > > Thanks, > > Jason Huynh > >
