Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/316
let's keep the example package to contain only examples.
On Mon, Dec 19, 2016 at 12:09 PM, Kevin Duling <notificati...@github.com>
wrote:
> *@kjduling* commented on this pull request.
> ------------------------------
>
> In geode-core/src/main/java/org/apache/geode/examples/security/
> ExampleSecurityManager.java <https://github.com/apache/geode/pull/316>:
>
> > List<ResourcePermission> permissions = new ArrayList<>();
> +
>
> Originally, yes, they were in the same package. Then, after
> SampleSecurityManager was moved to ExampleSecurityManager and
> TestSecurityManger, the test was testing TestSecurityManager, which is
> silly. A test to test a test? By changing the test to point to
> ExampleSecurityManager, scope became an issue.
>
> We could also just move the test to the same package as the example and
> remove the accessors and public scope on the inner classes. Either is fine
> with me.
>
> â
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/geode/pull/316>, or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AO6fkmr1fpyCEz1IHZKAP1JDdo2We37Oks5rJuR2gaJpZM4LNb_H>
> .
>
--
Cheers
Jinmei
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
