Github user kjduling commented on a diff in the pull request:
https://github.com/apache/geode/pull/316#discussion_r93109555
--- Diff:
geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
---
@@ -257,15 +257,65 @@ private void readUsers(final Map<String, User>
rolesToUsers, final JsonNode node
return roleMap;
}
- static class Role {
+ public static class Role {
List<ResourcePermission> permissions = new ArrayList<>();
+
--- End diff --
Originally, yes, they were in the same package. Then, after
SampleSecurityManager was moved to ExampleSecurityManager and
TestSecurityManger, the test was testing TestSecurityManager, which is silly.
A test to test a test? By changing the test to point to
ExampleSecurityManager, scope became an issue.
We could also just move the test to the same package as the example and
remove the accessors and public scope on the inner classes. Either is fine
with me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
