Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90078053
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
---
@@ -138,8 +127,8 @@ public void allocatedResourceInstance(ResourceInstance
resourceInstance) {}
public void destroyedResourceInstance(ResourceInstance resourceInstance)
{}
/** For testing only */
- List<StatisticsMonitor> getMonitorsSnapshot() {
- return Collections.unmodifiableList(this.monitors);
+ ConcurrentHashSet<StatisticsMonitor> getMonitorsSnapshot() {
--- End diff --
Maybe this ought to just return a Collection?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
