Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90025338
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatisticsMonitor.java
---
@@ -29,23 +29,20 @@
private final Object mutex = new Object();
- private volatile List<StatisticsListener> listeners =
Collections.<StatisticsListener>emptyList();
+ private volatile ConcurrentHashSet<StatisticsListener> listeners =
--- End diff --
Instead of `volatile` I think this should be final. I don't see a write to
this var after initialization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
