[
https://issues.apache.org/jira/browse/GEARPUMP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515213#comment-15515213
]
ASF GitHub Bot commented on GEARPUMP-204:
-----------------------------------------
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r80175062
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -115,15 +116,24 @@ object HBaseSink {
val COLUMN_NAME = "hbase.table.column.name"
val HBASE_USER = "hbase.user"
- def apply[T](userconfig: UserConfig, tableName: String): HBaseSink = {
- new HBaseSink(userconfig, tableName)
- }
def apply[T](userconfig: UserConfig, tableName: String, configuration:
Configuration)
- : HBaseSink = {
+ : HBaseSink = {
new HBaseSink(userconfig, tableName, configuration)
}
+ def apply[T](
--- End diff --
Code format
> Add unit test for external_hbase module
> ---------------------------------------
>
> Key: GEARPUMP-204
> URL: https://issues.apache.org/jira/browse/GEARPUMP-204
> Project: Apache Gearpump
> Issue Type: Improvement
> Reporter: Manu Zhang
> Assignee: Kaifang Bao
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
