[
https://issues.apache.org/jira/browse/GEARPUMP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515019#comment-15515019
]
ASF GitHub Bot commented on GEARPUMP-204:
-----------------------------------------
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r80167763
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -114,16 +118,19 @@ object HBaseSink {
val COLUMN_FAMILY = "hbase.table.column.family"
val COLUMN_NAME = "hbase.table.column.name"
val HBASE_USER = "hbase.user"
-
- def apply[T](userconfig: UserConfig, tableName: String): HBaseSink = {
- new HBaseSink(userconfig, tableName)
- }
+ private val CONFIG = HBaseConfiguration.create()
--- End diff --
will configuration be created at client side ?
> Add unit test for external_hbase module
> ---------------------------------------
>
> Key: GEARPUMP-204
> URL: https://issues.apache.org/jira/browse/GEARPUMP-204
> Project: Apache Gearpump
> Issue Type: Improvement
> Reporter: Manu Zhang
> Assignee: Kaifang Bao
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
