> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, April 12, 2017 4:16 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH] eal: redefine logtype values > > 2017-04-12 15:14, Pablo de Lara: > > After the changes in commit c1b5fa94a46f > > ("eal: support dynamic log types"), logtype is not treated as a > > bitmask, but a decimal value. Therefore, values have to be > > converted. > > > > Fixes: c1b5fa94a46f ("eal: support dynamic log types") > > > > Signed-off-by: Pablo de Lara <pablo.de.lara.gua...@intel.com> > [...] > > /* SDK log type, keep sync'd with rte_log_init() */ > [...] > > +#define RTE_LOGTYPE_EAL 0 /**< Log related to eal. */ > > +#define RTE_LOGTYPE_MALLOC 1 /**< Log related to malloc. */ > > +#define RTE_LOGTYPE_RING 2 /**< Log related to ring. */ > > +#define RTE_LOGTYPE_MEMPOOL 3 /**< Log related to mempool. */ > > +#define RTE_LOGTYPE_TIMER 4 /**< Log related to timers. */ > > +#define RTE_LOGTYPE_PMD 5 /**< Log related to poll mode driver. > */ > > +#define RTE_LOGTYPE_HASH 6 /**< Log related to hash table. */ > > +#define RTE_LOGTYPE_LPM 7 /**< Log related to LPM. */ > > +#define RTE_LOGTYPE_KNI 8 /**< Log related to KNI. */ > > +#define RTE_LOGTYPE_ACL 9 /**< Log related to ACL. */ > > +#define RTE_LOGTYPE_POWER 10 /**< Log related to power. */ > > +#define RTE_LOGTYPE_METER 11 /**< Log related to QoS meter. */ > > +#define RTE_LOGTYPE_SCHED 12 /**< Log related to QoS port > scheduler. */ > > +#define RTE_LOGTYPE_PORT 13 /**< Log related to port. */ > > +#define RTE_LOGTYPE_TABLE 14 /**< Log related to table. */ > > +#define RTE_LOGTYPE_PIPELINE 15 /**< Log related to pipeline. */ > > +#define RTE_LOGTYPE_MBUF 16 /**< Log related to mbuf. */ > > +#define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */ > > +#define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > > +#define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */ > > I think you should use these values in rte_log_init, > instead of the hardcoded ones. > So the messages about keeping them sync'd could be removed :)
Good idea, will send a v2 shortly.
