01/07/2025 13:42, Vanshika Shukla: > From: Stephen Hemminger <step...@networkplumber.org> > > On Wed, 11 Jun 2025 12:40:36 +0530 > > vanshika.shu...@nxp.com wrote: > > > > > From: Vinod Pullabhatla <vinod.pullabha...@nxp.com> > > > > > > Add support to set Tx rate on DPAA platform through PMD APIs > > > > > > Signed-off-by: Vinod Pullabhatla <vinod.pullabha...@nxp.com> > > > Signed-off-by: Vanshika Shukla <vanshika.shu...@nxp.com> > > > --- > > > > You intended to add a PMD specific API for rate limiting. > > But there is no RTE_EXPORT_SYMBOL so it was never used. > > > > You would have found this if you added a test for it. > > > > Not accepting this without a test in test-pmd for it. > > > > And why is the existing ethdev queue rate_limit not a better API here? > > We have exported the API and are currently testing it using our internal > application. This feature is specific to our platform. > > The existing ethdev queue rate_limit API supports per-queue rate limiting. > However, our use case requires per-port rate limiting, so we have implemented > a custom solution to support this functionality.
You should make a port-level generic API. PMD-specific API should be avoided.
