Hi Stephen, We have exported the API and are currently testing it using our internal application. This feature is specific to our platform.
The existing ethdev queue rate_limit API supports per-queue rate limiting. However, our use case requires per-port rate limiting, so we have implemented a custom solution to support this functionality. Regards, Vanshika > -----Original Message----- > From: Stephen Hemminger <step...@networkplumber.org> > Sent: 29 June 2025 22:13 > To: Vanshika Shukla <vanshika.shu...@nxp.com> > Cc: dev@dpdk.org; Thomas Monjalon <tho...@monjalon.net>; Hemant > Agrawal <hemant.agra...@nxp.com>; Sachin Saxena > <sachin.sax...@nxp.com>; Vinod Pullabhatla > <vinod.pullabha...@nxp.com> > Subject: [EXT] Re: [v4 07/10] net/dpaa: add Tx rate limiting DPAA PMD API > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On Wed, 11 Jun 2025 12:40:36 +0530 > vanshika.shu...@nxp.com wrote: > > > From: Vinod Pullabhatla <vinod.pullabha...@nxp.com> > > > > Add support to set Tx rate on DPAA platform through PMD APIs > > > > Signed-off-by: Vinod Pullabhatla <vinod.pullabha...@nxp.com> > > Signed-off-by: Vanshika Shukla <vanshika.shu...@nxp.com> > > --- > > You intended to add a PMD specific API for rate limiting. > But there is no RTE_EXPORT_SYMBOL so it was never used. > > You would have found this if you added a test for it. > > Not accepting this without a test in test-pmd for it. > > And why is the existing ethdev queue rate_limit not a better API here?