> -----Original Message-----
> From: Stephen Hemminger <[email protected]>
> Sent: Thursday, February 23, 2023 5:56 AM
> To: [email protected]
> Cc: Stephen Hemminger <[email protected]>; Yipeng Wang 
> <[email protected]>;
> Sameh Gobriel <[email protected]>; Bruce Richardson 
> <[email protected]>;
> Vladimir Medvedkin <[email protected]>; Ruifeng Wang 
> <[email protected]>
> Subject: [PATCH v11 21/22] hash: move rte_hash_set_alg out header
> 
> The code for setting algorithm for hash is not at all perf sensitive, and 
> doing it inline
> has a couple of problems. First, it means that if multiple files include the 
> header, then
> the initialization gets done multiple times. But also, it makes it harder to 
> fix usage of
> RTE_LOG().
> 
> Despite what the checking script say. This is not an ABI change, the previous 
> version
> inlined the same code; therefore both old and new code will work the same.
> 
> Signed-off-by: Stephen Hemminger <[email protected]>
> ---
>  lib/hash/meson.build     |  1 +
>  lib/hash/rte_crc_arm64.h |  8 ++---
>  lib/hash/rte_crc_x86.h   | 10 +++---
>  lib/hash/rte_hash_crc.c  | 68 ++++++++++++++++++++++++++++++++++++++++
>  lib/hash/rte_hash_crc.h  | 48 ++--------------------------
>  lib/hash/version.map     |  7 +++++
>  6 files changed, 88 insertions(+), 54 deletions(-)  create mode 100644
> lib/hash/rte_hash_crc.c
> 
Acked-by: Ruifeng Wang <[email protected]>

Reply via email to