> -----Original Message----- > From: Ruifeng Wang > Sent: Thursday, February 23, 2023 3:11 PM > To: Stephen Hemminger <[email protected]>; [email protected] > Cc: Yipeng Wang <[email protected]>; Sameh Gobriel > <[email protected]>; Bruce > Richardson <[email protected]>; Vladimir Medvedkin > <[email protected]>; > nd <[email protected]> > Subject: RE: [PATCH v11 21/22] hash: move rte_hash_set_alg out header > > > -----Original Message----- > > From: Stephen Hemminger <[email protected]> > > Sent: Thursday, February 23, 2023 5:56 AM > > To: [email protected] > > Cc: Stephen Hemminger <[email protected]>; Yipeng Wang > > <[email protected]>; Sameh Gobriel <[email protected]>; > > Bruce Richardson <[email protected]>; Vladimir Medvedkin > > <[email protected]>; Ruifeng Wang <[email protected]> > > Subject: [PATCH v11 21/22] hash: move rte_hash_set_alg out header > > > > The code for setting algorithm for hash is not at all perf sensitive, > > and doing it inline has a couple of problems. First, it means that if > > multiple files include the header, then the initialization gets done > > multiple times. But also, it makes it harder to fix usage of RTE_LOG(). > > > > Despite what the checking script say. This is not an ABI change, the > > previous version inlined the same code; therefore both old and new code > > will work the > same. > > > > Signed-off-by: Stephen Hemminger <[email protected]> > > --- > > lib/hash/meson.build | 1 + > > lib/hash/rte_crc_arm64.h | 8 ++--- > > lib/hash/rte_crc_x86.h | 10 +++--- > > lib/hash/rte_hash_crc.c | 68 > > ++++++++++++++++++++++++++++++++++++++++ > > lib/hash/rte_hash_crc.h | 48 ++-------------------------- > > lib/hash/version.map | 7 +++++ > > 6 files changed, 88 insertions(+), 54 deletions(-) create mode > > 100644 lib/hash/rte_hash_crc.c > > > > diff --git a/lib/hash/meson.build b/lib/hash/meson.build index > > e56ee8572564..c345c6f561fc > > 100644 > > --- a/lib/hash/meson.build > > +++ b/lib/hash/meson.build > > @@ -19,6 +19,7 @@ indirect_headers += files( > > > > sources = files( > > 'rte_cuckoo_hash.c', > > + 'rte_hash_crc.c', > > I suppose this list is alphabetically ordered. > > > 'rte_fbk_hash.c', > > 'rte_thash.c', > > 'rte_thash_gfni.c' > <snip> > > diff --git a/lib/hash/rte_hash_crc.h b/lib/hash/rte_hash_crc.h index > > 0249ad16c5b6..e8145ee44204 100644 > > --- a/lib/hash/rte_hash_crc.h > > +++ b/lib/hash/rte_hash_crc.h > > @@ -20,8 +20,6 @@ extern "C" { > > #include <rte_branch_prediction.h> > > #include <rte_common.h> > > #include <rte_config.h> > > -#include <rte_cpuflags.h> > > A couple of files need update with this change. > rte_cpuflags.h should be included in rte_fbk_hash.c (for ARM) and rte_efd.c.
OK, I see the changes already there in other patches in the same series. Please ignore this comment. Thanks. > > > -#include <rte_log.h> > > > > #include "rte_crc_sw.h" > > > <snip>
