22/02/2023 09:24, Morten Brørup: > > From: Thomas Monjalon [mailto:[email protected]] > > Sent: Wednesday, 22 February 2023 09.01 > > > > 21/02/2023 21:18, Kamalakshitha Aligeri: > > > Hi Thomas, > > > > > > Do you want me to squash the unit tests in the mempool lib patch or do I > > have to wait for the reviews from mempool maintainers > > > > Yes I think you can do the squash if Morten agrees. > > Yes, I agree. And if there are any more changes required before the code is > accepted by the maintainers, I will let Kamalakshitha make those changes. > > > How should the different acks/review tags be handled when squashing two > patches into one? > > The library patch has: > > Signed-off-by: Morten Brørup <[email protected]> > Acked-by: Konstantin Ananyev <[email protected]> > Acked-by: Chengwen Feng <[email protected]> > Acked-by: Kamalakshitha Aligeri <[email protected]> > > And the test patch has: > > Signed-off-by: Kamalakshitha Aligeri <[email protected]> > Reviewed-by: Ruifeng Wang <[email protected]> > Reviewed-by: Feifei Wang <[email protected]> > Acked-by: Morten Brørup <[email protected]>
The cleanest is to remove Reviewed and Acked-by and let reviewer check again. About the sign-off, you keep both. About the authorship, you must choose one.
