> From: Thomas Monjalon [mailto:[email protected]] > Sent: Wednesday, 22 February 2023 09.01 > > 21/02/2023 21:18, Kamalakshitha Aligeri: > > Hi Thomas, > > > > Do you want me to squash the unit tests in the mempool lib patch or do I > have to wait for the reviews from mempool maintainers > > Yes I think you can do the squash if Morten agrees.
Yes, I agree. And if there are any more changes required before the code is accepted by the maintainers, I will let Kamalakshitha make those changes. How should the different acks/review tags be handled when squashing two patches into one? The library patch has: Signed-off-by: Morten Brørup <[email protected]> Acked-by: Konstantin Ananyev <[email protected]> Acked-by: Chengwen Feng <[email protected]> Acked-by: Kamalakshitha Aligeri <[email protected]> And the test patch has: Signed-off-by: Kamalakshitha Aligeri <[email protected]> Reviewed-by: Ruifeng Wang <[email protected]> Reviewed-by: Feifei Wang <[email protected]> Acked-by: Morten Brørup <[email protected]> > > > > From: Thomas Monjalon <[email protected]> > > > 10/02/2023 08:33, Morten Brørup: > > > > > From: Kamalakshitha Aligeri [mailto:[email protected]] > > > > > Sent: Friday, 10 February 2023 07.54 > > > > > > > > > > Added mempool test cases with zero-copy get and put API's > > > > > > > > > > Signed-off-by: Kamalakshitha Aligeri <[email protected]> > > > > > Reviewed-by: Ruifeng Wang <[email protected]> > > > > > Reviewed-by: Feifei Wang <[email protected]> > > > > > > > > I already acked v1 of this patch, but here it is again for Patchwork: > > > > > > > > Acked-by: Morten Brørup <[email protected]> > > > > > > > > > --- > > > > > Link: > > > > > > > > https://patchwork.dpdk.org/project/dpdk/patch/20230209145833.129986-1- > > > > > [email protected]/ > > > > > > > > @David, here's the zero-copy mempool cache API test cases you were > > > asking for. > > > > > > The unit tests should be squashed in the mempool lib patch. > > > > > > Also I would to see a review from the mempool maintainers.
