> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Wednesday, October 14, 2020 3:14 PM > To: Bruce Richardson <bruce.richard...@intel.com>; Ruifeng Wang > <ruifeng.w...@arm.com> > Cc: Omkar Maslekar <omkar.masle...@intel.com>; dev@dpdk.org; > ciara.lof...@intel.com; d...@linux.vnet.ibm.com; jer...@marvell.com; > Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>; nd <n...@arm.com> > Subject: Re: [dpdk-dev] [PATCH v6] eal: add cache-line demote support > > On Tue, Oct 13, 2020 at 6:21 PM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > 1. Experimental tag is only needed in this file. Tags at other places can > > > be > removed. > > > > I'm not sure that is the case. The generic file is used when preparing > > the docs, so the experimental tag needs to go there for the docs, but > > when actually using the function in compiled code the "generic" > > version is unused. Therefore we need the experimental tag there to > > trigger a build warning about using the function if the appropriate > > ALLOW_EXPERIMENTAL_APIS flag is not set. > > It is enough to put an experimental tag when declaring a symbol. > Here, the generic/ header only contains the doxygen part and there is no > common declaration: the tag is needed in the arch specific header. > Thank you David for the clarification.
I added my reviewed-by tag to v7. > > -- > David Marchand
