ottlinger commented on code in PR #301:
URL: https://github.com/apache/creadur-rat/pull/301#discussion_r1760331130
##########
apache-rat-tools/src/test/java/org/apache/rat/tools/NamingTest.java:
##########
@@ -181,10 +181,4 @@ private void assertContains(String expected, List<String>
actual) {
private void assertNotContains(String expected, List<String> actual) {
assertFalse(actual.contains(expected), () -> "Contains "+expected);
}
-
- @Test
Review Comment:
If I'm not too mistaken I added these tests to validate the NPE-safeness of
the Naming class? Is that not needed anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
