ottlinger commented on code in PR #301:
URL: https://github.com/apache/creadur-rat/pull/301#discussion_r1760316922
##########
apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/impl/base/XmlWriter.java:
##########
@@ -627,6 +627,39 @@ public IXmlWriter closeElement() throws IOException {
return this;
}
+ /**
+ * Closes back to and including the last instance of the specified element
nema.
+ * @param name The name of the element to close.
+ * @return this object
+ * @throws OperationNotAllowedException if called before any call to
+ * {@link #openElement} or after the first element has been closed
+ */
+ @Override
+ public IXmlWriter closeElement(CharSequence name) throws IOException {
Review Comment:
Is NPE-safeness an issue here? Should we throw an exception if invalid/null
is passed in here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
