I don't think there is as simple a way to identify those since there
are many ways you can specify a single token.

Kind Regards,
Brandon



On Thu, Feb 15, 2024 at 11:45 AM Jacek Lewandowski
<lewandowski.ja...@gmail.com> wrote:
>
> Brandon, that should be doable with the current filters I think - that is, 
> select only those tests which do not support vnodes. Do you know about such 
> in-jvm dtests as well?
>
> - - -- --- ----- -------- -------------
> Jacek Lewandowski
>
>
> czw., 15 lut 2024 o 18:21 Brandon Williams <dri...@gmail.com> napisał(a):
>>
>> On Thu, Feb 15, 2024 at 1:10 AM Jacek Lewandowski
>> <lewandowski.ja...@gmail.com> wrote:
>> > For dtests we have vnodes/no-vnodes, offheap/onheap, and nothing about 
>> > other stuff. To me running no-vnodes makes no sense because no-vnodes is 
>> > just a special case of vnodes=1. On the other hand offheap/onheap buffers 
>> > could be tested in unit tests. In short, I'd run dtests only with the 
>> > default and latest configuration.
>>
>> I largely agree that no-vnodes isn't useful, but there are some
>> non-vnode operations like moving a token that don't work with vnodes
>> and still need to be tested.  I think we could probably get quick
>> savings by breaking out the @no_vnodes tests to a separate suite run
>> so we aren't completely doubling our effort for little gain with every
>> commit.

Reply via email to