On Thu, Feb 15, 2024 at 1:10 AM Jacek Lewandowski <lewandowski.ja...@gmail.com> wrote: > For dtests we have vnodes/no-vnodes, offheap/onheap, and nothing about other > stuff. To me running no-vnodes makes no sense because no-vnodes is just a > special case of vnodes=1. On the other hand offheap/onheap buffers could be > tested in unit tests. In short, I'd run dtests only with the default and > latest configuration.
I largely agree that no-vnodes isn't useful, but there are some non-vnode operations like moving a token that don't work with vnodes and still need to be tested. I think we could probably get quick savings by breaking out the @no_vnodes tests to a separate suite run so we aren't completely doubling our effort for little gain with every commit.
