>> - It looks like there might be compiled code in the release? [1][2]
Non issue. Test resources. >> - LICENSE is missing some 3rd party code license information [5] This >> contains code "Copyright DataStax, Inc." under ALv2, python-smhasher under >> MIT, OrderedDict under MIT (copyright Raymond Hettinger) and code from >> MagnetoDB under ALv2. CASSANDRA-18807 >> - LICENSE has no mention of 3rd party CRC code in [10] >> - Note that any code under CC 4.0 is incompatible with the ALv2. [11] This comes down to using an int number from Philip Koopman's CRC work. `private static final int CRC24_POLY = 0x1974F0B;` It was questioned whether a number can be copyrighted, in which case we would not be including third-party work here. The code comment explains this too. Benedict? >> - LICENSE also doesn't mention this file [9] CASSANDRA-18807 >> - In LICENSE LongTimSort.java incorrectly mentions two different copyright >> owners >> - In LICENSE, AbstractGuavaIterator.java is incorrectly mentioned as >> AbstractIterator.java CASSANDRA-18807 >> - NOTICE seems OK but may also be missing some things due to missing 3rd >> party code in LICENSE under ALv2 No additions required. >> - Files are missing ASF headers [3][4][6][7][8] are these 3rd party files? Non issue. Doc files, or third-party files. Dockerfiles fixed in CASSANDRA-18807 > 1../test/data/serialization/3.0/utils.BloomFilter1000.bin > 2. ./test/data/serialization/4.0/utils.BloomFilter1000.bin > 3. ./doc/modules/cassandra/examples/BASH/*.sh > 4. ./pylib/Dockerfile.ubuntu.* > 5. ./lib/cassandra-driver-internal-only-3.25.0.zip > 6. ./lib/cassandra-driver-3.25.0/cassandra/murmur3.py > 7. ./lib/cassandra-driver-3.25.0/cassandra/io/asyncioreactor.py > 8 ./lib/cassandra-driver-3.25.0/cassandra/io/libevwrapper.c > 9. ./tools/fqltool/src/org/apache/cassandra/fqltool/commands/Dump.java > 10. ./src/java/org/apache/cassandra/net/Crc.java > 11. https://www.apache.org/legal/resolved.html#cc-by
