> I am fine with Jenkins or CircleCI; though I feel CircleCI is more effort > for each member.
ASF policy is that patches from contributors that haven't a ICLA filed can not have their patches automatically run through any ASF CI system. It's up to a committer (or someone who has filed a ICLA) to trigger the test run on the patch. > The finer granularity of code review comments can also be on the github > > commit pages, again you don't need to open the PR > > > I just tested this out and what I see is the following > > 1) branch has a jira link, so PR comments make it into jira > 2) going to the commit and commenting *does not* go into jira. (2) is The Right Thing™ IMHO. Keep low-level code review out of the jira ticket. I think a number of people complained about the noise of PR comments coming back into the jiras. Another reason to do the review on the commit instead of the PR, but again just an opinion and one way to do it. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
