On Thu, Jan 23, 2020 at 6:18 AM Jeremiah Jordan <jerem...@datastax.com> wrote:
> Can’t you currently open a PR with the right commit message, have do > review there with all comments posted back to JIRA, run CI on it and then > merge it closing the PR? This is the basic workflow you are proposing yes? > > Yes you can. > It is the reviewer and authors job to make sure CI ran and didn’t > introduce new failing tests, it doesn’t matter how they were ran. It is > just as easy to let something through when “pr triggered” tests have a > failure as it is tests manually linked from a JIRA comment, if the author > and reviewer think the failures are not new. > Agreed. Any committer who commits while tests are broken is ignoring policy. Moving patch submission from one system to another won't somehow make committers adhere to policy. > > If someone want to setup some extra niceties, like auto triggered builds > or something, to happen if people use the PR workflow, then I see no > problem there. But I don’t think we need to force use of PRs. > > This is why I don’t think we need to “switch” to using PR’s. There is no > need to switch. People can “also” use PRs. If someone who likes the PR > workflow sets up some more nice stuff to happen when it is used, that would > probably encourage more people to do things that way. But it doesn’t need > to be forced. > Agreed.
