On 8/19/18 4:13 PM, Emilio Cobos Álvarez wrote:
On 8/19/18 9:54 PM, Josh Bowman-Matthews wrote:
On 8/19/18 2:10 PM, Anthony Ramine wrote:
We don't make use of rustfmt yet though (right? I was under a rock
for 2 weeks so if I missed this excellent improvement, ignore me), so
let's do that first IMO.
Le 19 août 2018 à 19:43, Bobby Holley <bobbyhol...@gmail.com> a écrit :
rustfmt fits the bill, so I think it makes sense to retire
that particular tidy lint.
https://github.com/servo/servo/issues/21373 is tracking getting us
formatted so that we can turn rustfmt on everywhere by default. Once
we encounter the first cases of rustfmt's ordering not matching
test-tidy, we can disable Servo's use ordering lint in order to merge
those PRs.
We should probably re-enable rustfmt's import-reordering then[1], right?
I'll send a PR tomorrow if nobody wins me to that :)
-- Emilio
[1]:
https://github.com/servo/servo/blob/d34403047e806fa6c8c2468946f64429622ec434/rustfmt.toml#L4
Cheers,
Josh
_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo
Oh, I didn't realize we already had a configuration. If we can keep that
reordering disabled until we're done merging the rest of the rustfmt
changes, that will be easier in the long run. Then we can merge a mass
reordering of the entire project all at once and disable the tidy lint
at the same time as we turn on rustfmt on CI.
Cheers,
Josh
_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo
