On 25/08/16 20:55, Manish Goregaokar wrote:
I suspect they won't be too bad, and once stylo settles down a bit there
won't be many breaking changes.
I believe this is not at all the case.
We gave up a long time ago on reducing the API surface of the style
crate (what’s visible from other crates) and made everything public.
There is zero separation between public API and implementation details.
My experience is that, because of that, most changes to style are
breaking changes that require some other crate (typically script or/and
layout) to be updated as well.
The problem with breaking changes is that once that more than one of
them lands upstream, their order is linearized. For example, we recently
published versions 0.9.0, then 0.10.0, then 0.11.0 of the 'selectors'
crate within a few days. There was a PR to update Servo to 0.10.0, but
we’ve had to wait until it was reviewed and merged (which took days with
the usual CI bots babysitting because of intermittent failures) before
we could take advantage in servo of the features introduced in 0.11.0.
Sorry this message is all negative without proposing an alternative, but
I’m very wary of this proposal.
--
Simon Sapin
_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo
