Hi Manish, Your proposal scares me in the sense that (if I read it well) it would be at least temporarily allowing changing the style system without gating on Servo. There are architectural changes to the style system that work for Gecko, but would completely break Servo.
Right now landing a change like this means being sure you're able to generalize enough so it works for both layout systems. If we don't gate on Servo, this phase would get postponed, and I think that's extremely dangerous. Also, I'm skeptical about the amount of breaking changes being drastically reduced in a reasonable time-frame, as you suggest. -- Emilio On 08/25/2016 12:34 PM, Manish Goregaokar wrote: >> The other proposal includes making sure Gecko related stylo changes >> don't break Servo, but this does not. It seems easy enough to add >> Servo's test suite to the m-c side CI, so I would propose to add that >> to your proposal. That means we only have to resolve conflicts until >> CI is fully baked instead of forever. >> >> > This brings up the issue that changes to m-c's vendor may require changes > to servo/servo, > which has the same set of problems, bringing us back to square 1 where we > just vendor > all the things. > > Not gating on Servo's CI means that we can just handle it during the sync. > > (Optional non-gated CI sounds nice to have though) > > >> Bobby's claim was that almost all changes are breaking ones. If that's >> true, I don't see how we're going to avoid people needing to fix up >> the Gecko side. But at least with your proposal that more explicitly >> limited to the style system. While in theory that shouldn't make a >> difference, I think this will make it easier to deal with problems >> like intermittents. For example, there's no way a change to >> servo/servo itself could trigger intermittents on the Gecko side. >> >> > Temp-branching until a weekly sync is a solution here. Such a solution isn't > available in frankenbuild at all -- style-api-breaking-changes must be > coordinated > across repos.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
