On Wed, Nov 11, 2015 at 6:31 PM, Bobby Holley <bobbyhol...@gmail.com> wrote: > > From a project standpoint, I am trying to blaze the trail of the > committer-but-not-reviewer role
IME having to re-get r+ every time you have a trivial merge conflict or minor CI failure (e.g. a "tidy" failure due to trailing whitespace) is a huge PITA. I remember one bug where I had to ask gw four times over the course of an entire day to re-give r+ for such things. It's infantilising, and I'm 95% sure he didn't look at my code changes -- he didn't review the original patch. On the other hand, I'm more optimistic than bholley about the per-bug delegation. Given that it's been implemented I'd suggest using it and if reviewers do tend to forget it then consider implementing a broader mechanism. Nick _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
