Thanks for working on this Manish! As mentioned previously, I think that scoping this bit of trust to the PR is sub-optimal. This kind of delegation is effectively unsupervised write access to the repository, with an understanding that the committer is trustworthy enough to ask for review on any significant not-yet-approved changes. It doesn't really have anything to do with the particular PR, and has everything to do with the person being granted that access.
This kind of trust is a governance issue, and making it a per-reviewer per-PR preference introduces the following problems: * The committer needs to establish the trust relationship with each individual reviewer, which doesn't scale for either party. * Reviewers need to make an important trust decision for every PR, and may not always make decisions that are consistent with what they and others have decided previously. * Reviewers may not always remember to set the delegate flag. The combination of all three of the above means that, in practice, a contributor is likely to find themselves with carry privileges in some situations but not others. Is that ever desirable? bholley On Wed, Nov 11, 2015 at 3:01 AM, Manish Goregaokar <manishsm...@gmail.com> wrote: > After some > <https://github.com/servo/servo/wiki/Meeting-2015-11-02#review-carry-over> > discussion > < > http://logs.glob.uno/?c=mozilla%23servo&s=10+Nov+2015&e=10+Nov+2015&h=delegate#c298415 > > > I've landed <https://github.com/barosl/homu/pull/111> and enabled review > delegation for homu. > > This means that any homu command containing `delegate=USER` will give that > user full reviewer status for the scope of that PR (i.e., they can use all > homu commands for that PR). You can also use `delegate+` as a shortcut to > delegate to the PR author. `delegate-` undoes delegation. > > Reviewers: In case of "r=me with minor nit" situations (where the author is > trusted enough to not add our infra to a botnet or whatever), try to use > `@bors-servo delegate+` so that the author can finish up the PR on their > own. This should ease up the workflow for non-reviewers. > > You can see it in action here <https://github.com/servo/saltfs/pull/160>. > > Thanks, > -Manish Goregaokar > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
