On 28/02/2014 01:07, Patrick Walton wrote:
Hi everyone,

In an effort to future-proof our code for bidi and vertical writing [1],
I'm wondering whether we should go through and rename our directions
used throughout Servo to correspond to the abstract dimensions used in
CSS3 writing modes,

I think we should.


and if so, what to name them.

I suppose we have the following options for "flow-relative directions":

1.
"block-start"/"block-end"/"inline-start"/"inline-end"/"extent"/"measure"
(spec option A);

2.
"block-start"/"block-end"/"inline-start"/"inline-end"/"logical-width"/"logical-height"
(spec option B);

In general I prefer using spec terminology, but in this specific case I don’t really like either extent/measure (too foreign, not obvious which is which) not logical-width/logical-height (too "physical-like").

Gecko (see layout/generic/WritingModes.h) uses inline-size and block-size, which nicely preserves the pattern of block-start/block-end/inline-start/inline-end. In APIs, it also abbreviates inline-foo and block-foo to IFoo and BFoo, respectively.


3. "top"/bottom"/"left"/"right"/"width"/"height" (today);

4. Same as (3), but with "logical" added.

And for "line-relative directions":

1. "over"/"under"/"line-left"/"line-right" (spec);

2. "top"/"bottom"/"left"/"right" (today);

3. Same as (2), but with "logical" added.

Opinions?


--
Simon Sapin
_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo

Reply via email to