On Mon, Mar 25, 2019 at 10:05 PM <d...@mozilla.com> wrote: > > As far as separating the value; it kind of depends on how you > > implement it; but let's say you were going to use a static uint64_t or > > something like that. Instead of heaving a static uint64_t, create a > > Dictionary<OriginAttributes, uint64_t> and look up the uint64_t using > > the OriginAttrbutes of the top level page. > > > > > Regarding to `touchid, IIUC, it is a data member of a Gamepad, that means the > attribute wouldn't be accessed across other pages. For examples, a gamepad > whose `touchid` is 6 and `timestamp` is 5000 in a gamepad tab, when visiting > to an another Gamepad tab, we will spawn a new gamepad object for this tab > and its `touchid` and `timestamp` are 0. Therefore, I could not finding the > possible usage case of OriginAttrbutes.
Oh, excellent, then the desired behavior is already built in. > > Also, as Ehsan mentioned, we should change the spec so that touchId is > > keyed by the top level domain. > > > > > In our implementation, we will wait until users' first intention like > > > button press, axis movement. Then, Firefox will fire a > > > `gamepadconnected`[1]. Chrome also does the same restriction although the > > > spec doesn't describe this is a must. > > > > > > Regarding to GamepadPose, we only implement it for VR controllers, we > > > only can start to poll input events once users confirm they wanna enter > > > the VR mode. Then, keep waiting for the first event like button press, > > > axis movement, or pose change. Lastly, we will fire a `gamepadconnected`. > > > Also, once they switch the VR tab to the background, we will close this > > > VR session and don't listen to VR input events any more. > > > > Okay, good, not making this data available until the user activity > > engages with the gamepad/VR controller (mostly) assuages my concerns > > on this component. My remaining concern is around the sensitivity of > > axis movement. If I have my controller on my desk, and I am > > typing/bumping it - I am curious if that would cause the controller to > > suddenly activate. I don't think I have a gamepad to test with > > though. > > > > -tom > > > For the sensitivity of axis movement, I aware Firefox needs do adjustments > for this part. The axis of gamepad in Firefox always gives its first intent > once its value is not 0. That means if some Gamepad axes value are not 0 even > they are idle, the gamepad will be activated immediately. I will fix this > issue shortly, I think 0.5 [0~1] threshold is a good value. (Chrome did the > same threadhold from my tests.) Excellent. On Mon, Mar 25, 2019 at 10:10 PM <d...@mozilla.com> wrote: > > There's a research question that suggests: gamepad accelerometers are > > pretty good, can they be used to recover what someone is typing based on > > those vibrations? Setting a minimum activation threshold to start using > > the controller might be wise. A button press is guaranteed to activate it, > > so we can be a little less sensitive for that. > > This is a good thought although not every gamepad has vibrate function. We > can do this enhancement for the devices own this functionality. I grabbed an XBox One controller (quite new, with good joysticks) and set it on my desk to run some tests. It activates when I move a joystick and informs the page. My normal typing does not activate it; however if I sit down at my desk and bump the desk or put my elbows on it with some (but not a painful amount) of force that also activates it. I suppose my ideal opinion here is that we only activate on button press rather than joystick but at the least increasing the threshold for the joystick is important. -tom _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
