It might be worth investigating whether we can switch Phabricator's default (so that multiple reviews are all blocking, and to make them non-blocking would require the extra step). Personally I think setting multiple reviewers up on a first come first serve is disrespectful to those reviewers' time, so shouldn't be the case that gets optimized.
Though I also like that the distinction can be made, and there are cases where first-come-first-serve would be a good idea (e.g things that need to land ASAP). On Tue, Jul 3, 2018 at 1:29 AM glob <g...@mozilla.com> wrote: > Jean-Yves Avenard wrote on 3/7/18 6:23 am: > > On Mon, Jul 2, 2018 at 5:01 PM, Andreas Tolfsen <a...@sny.no> wrote: > >> Also sprach Marco Bonardo: >> >> > When asking for review to multiple reviewers, and all of them must >> accept >> > your revision, you must mark them as blocking reviews, either in the >> > Phabricator ui or appending "!" at the end of the reviewer name. >> Otherwise >> > it's first-come-first-serve. >> >> Note that is and also has been the case for mozreview. >> > > I don't ever recall mozreview having different kind of reviewer (blocker > or non-blocker), if two people were added as reviewer, by default both had > to review. > > it's correct that mozreview (and bugzilla) only have one type of > reviewer. what multiple reviewers means in bugzilla/mozreview varies from > team to team (all must review vs. any can review). > > it isn't correct that in mozreview two reviewers would both have to review. > approval from _any_ reviewer would allow it to be landed with autoland: > > https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/pylib/mozreview/mozreview/review_helpers.py#l34 > > i like that phabricator makes this distinction up-front. > thanks mak for drawing attention to this difference/feature. > > > > -glob > -- > glob — engineering workflow — moz://a > > _______________________________________________ > firefox-dev mailing list > firefox-...@mozilla.org > https://mail.mozilla.org/listinfo/firefox-dev > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
