On 6/6/18 2:52 PM, Jan-Ivar Bruaroey wrote:
Sorry, I shouldn't have assumed. FWIW mozReview handles all this
exceedingly well today IMHO, using the "Diff Revision" slider, even for
the whole patch set.
Sort of. As long as people don't mess up their mozreview ids....
One example of "better" would be being able to see "the diff with the
first N patches applied"
Sounds exactly like what mozReview's "Diff Revision" slider does today.
No, not at all.
Say we have a tree at revision B. Someone writes three changesets P1,
P2, P3 on top of it and asks me for review.
Mozreview will show me the equivalent of "diff -r B -r P1", "diff -r P1
-r P2" and "diff -r P2 -r P3". If there are then edits to P1 to produce
Q1, the diff revision slider will let me choose between "diff -r B -r
Q1" and "diff -r P1 -r Q1".
But what I'm talking about is viewing "diff -r B -r P2" or "diff -r P1
-r P3". I don't believe mozreview provides this right now via its UI.
(as long as you never rebase your patches during review. Its INTER-diff
fails to weed out any new unrelated changes then, a longstanding bug
that sadly never got fixed).
It used to try to weed them out, but that produced interdiffs that
weeded out actual changes. This is a hard problem....
Basically, I want some equivalent to "hg bzexport" or something better
but for the new setup. Based on
http://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#series-of-commits
it sure sounds like that doesn't exist yet but is planned...
I guess I fail to see how that can be retrofitted... but what do I know.
Well... it sounds like right now you can do something in Differential
with dependent patches but you have to manually indicate they are
dependent. This is the part that could be automated/retrofitted.
Whether the dependent patches thing does the other stuff one would want
is not not clear to me.
-Boris
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
