On Thu, Apr 26, 2018, at 12:41 AM, Mark Côté wrote: > How we might use blocking reviewers in our workflow is still open, but > it could be used for training up reviewers, in which case the trainee > would be a regular reviewer and the module peer/owner would be a > blocking reviewer.
It's not uncommon for me to submit patches for review from multiple people where I require all reviewers to sign off on the patch, usually because I ask them to look at different parts of the patch. I don't think I have ever sent a patch to get review from more than one person with the intention of landing it if only one person OKs it. (I'd probably needinfo people to get that kind of feedback.) So ignoring potential new workflows like the training one you mention, I think I would exclusively use blocking reviewers. It's good to know that Phabricator will help me avoid accidentally landing patches when not all of my reviewers have signed off. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
