I like that our link handling is getting shared but would really love a fix for this bug in SVG <a> rendering: https://bugzilla.mozilla.org/show_bug.cgi?id=1366494
Robert: do you have time to fix that one while you're in there? Thanks! --Jet On Tue, Apr 10, 2018 at 1:09 AM, Gijs Kruitbosch <gijskruitbo...@gmail.com> wrote: > On 10/04/2018 09:03, Gijs Kruitbosch wrote: > >> On 09/04/2018 22:11, longs...@gmail.com wrote: >> >>> Summary: HTML anchor elements have ping, rel, referrerPolicy, relList, >>> hreflang, type and text properties. SVG anchor elements should support >>> these properties too according to the SVG 2 specification and >>> https://github.com/w3c/svgwg/issues/315. >>> >>> Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1451823 >>> >> >> I looked at the patch briefly, and I'm a bit confused about the state of >> <a ping> . Specifically, my understanding is that we don't currently ship >> it - it's behind a pref and it's off by default ( >> https://searchfox.org/mozilla-central/source/modules/libpref >> /init/all.js#303 ). However, we have support in the codebase. But it >> looks to me like the patch on the bug doesn't really check this pref >> (unsure if we expose <a>.ping for HTML if the pref is off) and doesn't >> alter the implementation. At a minimum, it looks to me like this check: >> >> https://searchfox.org/mozilla-central/source/docshell/base/n >> sPingListener.cpp#255-259 >> >> would need updating to actually support <a>.ping "properly" for SVG. >> > > Sorry for the repetitive post, but I neglected to actually make the point > I was trying to make. I can't really tell what the intent is from the > patch, but I would be hesitant to say that this "implements and ships" > 'ping' without any qualifications (in, say, release notes), because in > effect the pref will still be off and presumably this means pings won't get > sent (neither for HTML nor SVG links). > > > ~ Gijs > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
