Hi all, FYI, I just pushed a patch to nsPipe3.cpp that switches it to use MOZ_DIAGNOSTIC_ASSERT() instead of the weaker assertions it used to use. This class is used extensively throughout the browser and state problems can manifest as intermittent hangs, crashes, and memory leaks.
For example, we got lucky that we caught this intermittent in a debug build in automation: https://bugzilla.mozilla.org/show_bug.cgi?id=1397595 We currently have no idea how many release build sessions have run into this state inconsistency in the wild. The diagnostic assertions will help us catch these problems much sooner. We debated whether to wait until the FF58 merge next week or not. Switching to diagnostic assertions now may raise crash rates in the short term. We decided, however, that the ability to detect problems sooner before they hit the release channel outweighed the downsides of the increased nightly/dev-edition crashes. The diagnostic assertions were pushed in: https://bugzilla.mozilla.org/show_bug.cgi?id=1398942 Please let me know if you have any questions or concerns. Thanks. Ben _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
