On 02/11/2017 04:59 AM, Boris Zbarsky wrote:
The biggest worry for me is that inline style is never a "chrome sheet" in this sense.
That's a valid concern, but I think ignoring -moz-appearance has fairly benign effects in most cases. And as Jet pointed out to me, just landing it and see what breaks is standard procedure for unprefixing properties: https://bugzilla.mozilla.org/show_bug.cgi?id=775235 Anyway, I took a quick look at some add-on usage in XUL files: https://dxr.mozilla.org/addons/search?q=moz-appearance+file%3A*.xul Most uses appears to be "-moz-appearance:none" which is reasonably safe to ignore, and can be easily amended with a "appearance:none" if needed. For other values, I installed the first four add-ons that use non-none values and analyzed what effect ignoring -moz-appearance would have. "dnsqueries": https://dxr.mozilla.org/addons/source/addons/11806/chrome/content/dnsqueries.xul#42 The "-moz-appearance:textfield" has the effect of creating an extra border+padding around the input field. This causes the control to have extra height making the whole toolbar have more height than needed. Ignoring this -moz-appearance makes those "problems" go away and the toolbar and text control actually looks better (IMO). Also, the text control still works with no loss in function. "RDS Bar": https://dxr.mozilla.org/addons/source/addons/14581/chrome/content/dialogs/preferences/parameters/weather/window.xul#20 https://dxr.mozilla.org/addons/source/addons/14581/chrome/content/rdstb.xul#3492,3525 It appears this "weather" button is dead code, I couldn't find a way to enable it. "Print Edit": https://dxr.mozilla.org/addons/source/addons/193270/chrome/content/printedit-options.xul#123 <colorpicker style="-moz-appearance: menulist"> has the effect of adding a chevron to the button. Ignoring it makes it look like a standard color picker button (which is an improvement, IMO). There is no loss in function. "Smart Text" https://dxr.mozilla.org/addons/source/addons/161982/content/options.xul#16 The "-moz-appearance:textfield" has the effect of creating an extra border+padding around the input field. However, in this case it appears that the <h:style> (XHTML) element does count as a chrome sheet so there is no change in behavior for this add-on since the -moz-appearance is still honored. (IMO, it would actually have looked better without it). While this is a small sample, there were no problems detected. To the contrary, it actually looks like an improvement IMO. /Mats _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
